Drop compile-time deprecation warning #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it's about time to tag a new release also. |
scpeters
reviewed
Jan 21, 2022
| LANGUAGES CXX) | ||
|
|
||
| message(STATUS "JsonCpp Version: ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}") | ||
| set(PROJECT_SOVERSION 24) | ||
| set(PROJECT_SOVERSION 25) |
There was a problem hiding this comment.
I'm wondering why the SOVERSION is incremented for a patch release that doesn't break API or ABI? This causes downstream packages to need to be rebuilt on macOS
- jsoncpp 1.9.5 Homebrew/homebrew-core#92195
- Rebuild ignition-fuel-tools bottles for jsoncpp 1.9.5 osrf/homebrew-simulation#1780
I can open a separate issue to discuss this if that is a better venue
There was a problem hiding this comment.
I started a discussion about this in #1384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are only getting in the way. Nobody needs to see these at compile-time (even though I wish people would stop using these).